Skip to content
Failed

Changes

Summary

  1. DualView: Skip sync and modify for host-accessible memory space (details)
  2. [[maybe_unused]] (details)
  3. Label the fences (details)
  4. Add test (details)
  5. fix specifiers (details)
  6. fix specifiers (details)
  7. fix specifiers (details)
  8. fix specifiers (details)
  9. quick fix (details)
  10. Bump actions/upload-artifact from 4.6.0 to 4.6.1 (details)
  11. Bump actions/cache from 4.2.0 to 4.2.1 (details)
  12. Bump github/codeql-action from 3.28.9 to 3.28.10 (details)
  13. Extend CEA nightly tests to use C++ 20 (#7777) (details)
  14. Move Jenkins config to .jenkins directory (details)
  15. Move string creation in Kokkos_ExecPolicy to improve performances (details)
  16. CI: Merge sunspot-gitlab-ci.yml into alcf-gitlab-ci.yml (#7810) (details)
  17. Fix maybe-uninitialized warning with gcc/13.2.0 and c++20 (details)
  18. View Refactor: prepare BasicView for new View implementation (#7751) (details)
  19. Remediate code scanning alert #97 (#7812) (details)
  20. simd: fix a bug in scalar min/max (#7813) (details)
  21. Remove simd mask comparison operators that return by bool (details)
  22. [HIP] Fix atomic performance bug in atomic_fetch_op with [unsigned] long (details)
  23. Remove gtest filter in AMD MI300A build on HPSF CI (details)
  24. Add HPSF CI build running on NVIDIA P100 (#7815) (details)
  25. Retire kokkos llvm build on ORNL Jenkins (#7801) (details)
Commit 2e1c66c49a89121709064ef2c5c21552c61861fd by Daniel Arndt
DualView: Skip sync and modify for host-accessible memory space
The file was modifiedcontainers/src/Kokkos_DualView.hpp (diff)
The file was modifiedcontainers/src/Kokkos_DualView.hpp (diff)
The file was modifiedcontainers/src/Kokkos_DualView.hpp (diff)
The file was modifiedcontainers/unit_tests/TestDualView.hpp (diff)
The file was modifiedsimd/src/Kokkos_SIMD_Scalar.hpp (diff)
The file was modifiedsimd/src/Kokkos_SIMD_AVX2.hpp (diff)
The file was modifiedsimd/src/Kokkos_SIMD_AVX512.hpp (diff)
The file was modifiedsimd/src/Kokkos_SIMD_NEON.hpp (diff)
The file was modifiedsimd/src/Kokkos_SIMD_NEON.hpp (diff)
Commit 37878ceedafb3837a9cd7607a0ab9ee0e5bc6297 by noreply
Bump actions/upload-artifact from 4.6.0 to 4.6.1

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.0 to 4.6.1.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08...4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
The file was modified.github/workflows/scorecard.yml (diff)
The file was modified.github/workflows/releases.yml (diff)
Commit 771a4586eee97788b32ed295e21eabd281ca033b by noreply
Bump actions/cache from 4.2.0 to 4.2.1

Bumps [actions/cache](https://github.com/actions/cache) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/1bd1e32a3bdc45362d1e726936510720a7c30a57...0c907a75c2c80ebcb7f088228285e798b750cf8f)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
The file was modified.github/workflows/continuous-integration-smoketest.yml (diff)
The file was modified.github/workflows/performance-benchmark.yml (diff)
The file was modified.github/workflows/continuous-integration-osx.yml (diff)
The file was modified.github/workflows/continuous-integration-linux.yml (diff)
Commit 62cc2ad43b42e99c2489090a1e6a39b5f2f65fec by noreply
Bump github/codeql-action from 3.28.9 to 3.28.10

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.9 to 3.28.10.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/9e8d0789d4a0fa9ceb6b1738f7e269594bdd67f0...b56ba49b26e50535fa1e7f7db0f4f7b4bf65d80d)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
The file was modified.github/workflows/codeql.yml (diff)
The file was modified.github/workflows/scorecard.yml (diff)
Commit 47508e87b34c70f1769571742f3597b2173b16e6 by noreply
Extend CEA nightly tests to use C++ 20 (#7777)

* Extend CEA nightly tests to CXX20

* [skip appveyor] Allow to run on pull request for C++ 20 only

* Add guard to is_base_of_v

Fix 7779

* [skip ci] Revert "[skip appveyor] Allow to run on pull request for C++ 20 only"

This reverts commit a802e3a2de41642df9fc52511d2ddc708507a2ae.

* Fix condition and C++ 20 identification macro

* [skip appveyor] Allow to run on pull request for C++ 20 only

* [skip ci] Prevent to use for pull requests and reenable Nightly mode

* Rework conditional with Kokkos macros

* [skip appveyor] Revert "Prevent to use for pull requests and reenable Nightly mode"

This reverts commit 9f30692bb56197e94736b0e79764ba58153bfae3.

* Pretty up macro guard

* [ci skip] Revert "Revert "Prevent to use for pull requests and reenable Nightly mode""

This reverts commit 86497a14dfee1bdcf8e47e6129363d4419246993.
The file was modifiedcore/src/impl/Kokkos_SimpleTaskScheduler.hpp (diff)
The file was modified.github/workflows/nightly-cea.yml (diff)
Commit 101be08f3a758d7738f73fc70f16cabcf07ed28c by Bruno Turcksin
Move Jenkins config to .jenkins directory
The file was removed.jenkins_nightly
The file was removed.jenkins
The file was added.jenkins/continuous.groovy
The file was added.jenkins/nightly.groovy
Commit 4b875efbe4ffb489d6f143cfe9c02bf98f6ffb15 by paul.gannay
Move string creation in Kokkos_ExecPolicy to improve performances

String creation for a warning was done during each kernel invocation
even if the warning wasn't raised, causing overhead.
The file was modifiedcore/src/Kokkos_ExecPolicy.hpp (diff)
Commit 7785ad09cbf7c5c6edadf4388a96dbf21e30836c by noreply
CI: Merge sunspot-gitlab-ci.yml into alcf-gitlab-ci.yml (#7810)

* [skip ci] Merge sunspot-gitlab-ci.yml into alcf-gitlab-ci.yml

* [skip ci] Use artifacts for Polaris CI
The file was modified.gitlab/alcf-gitlab-ci.yml (diff)
The file was removed.gitlab/sunspot-gitlab-ci.yml
Commit 23d44d4ac261e993fc9ce51f05560578b57b0ffe by ndellin
Fix maybe-uninitialized warning with gcc/13.2.0 and c++20

Co-authored-by: Damien L-G <dalg24+github@gmail.com>
The file was modifiedcore/src/impl/KokkosExp_Host_IterateTile.hpp (diff)
Commit ccb09db023f253c6240386f56e87e3b64ef62e21 by noreply
View Refactor: prepare BasicView for new View implementation (#7751)

* prepare BasicView for new View implementation

* address some initial review comments

* address more reviewer comments

* fix formatting

* Catch invalid conversion mode in Layout to Mapping

* Using statement for BasicView in test

* Address Review suggestions

---------

Co-authored-by: Christian Trott <crtrott@sandia.gov>
The file was modifiedcore/src/View/Kokkos_BasicView.hpp (diff)
The file was addedcore/src/View/Kokkos_ViewAccessPreconditionsCheck.hpp
The file was modifiedcore/unit_test/view/TestBasicViewMDSpanConversion.cpp (diff)
The file was modifiedcore/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
The file was modifiedcore/src/View/Kokkos_ViewMapping.hpp (diff)
The file was modifiedcore/src/View/MDSpan/Kokkos_MDSpan_Accessor.hpp (diff)
The file was modifiedcore/unit_test/view/TestBasicView.hpp (diff)
Commit 5c3bbc67df3f07f103ce6ac30d1dd1792cd372ad by noreply
Remediate code scanning alert #97 (#7812)

* Remediate code scanning alert \#97

Fix https://github.com/kokkos/kokkos/security/code-scanning/97

* Fix CodeQL permissions

---------

Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
The file was modified.github/workflows/continuous-integration-stager.yml (diff)
The file was modified.github/workflows/codeql.yml (diff)
Commit 2057f17d4d9f371de23f3130b6861bc947690805 by noreply
simd: fix a bug in scalar min/max (#7813)

* simd: correctly detect intel llvm and fix a bug in scalar min/max
- Check if `__INTEL_LLVM_COMPILER` is defined to enable svml intrinsics
- Fix a bug in the min and max functions for the scalar abi

* simd: revert the changes to the intel llvm compiler macro
The file was modifiedsimd/src/Kokkos_SIMD_Common_Math.hpp (diff)
Commit 7456b860511e18177116b5489d1ab79fd3a9bd0a by donlee
Remove simd mask comparison operators that return by bool
The file was modifiedsimd/src/Kokkos_SIMD_NEON.hpp (diff)
The file was modifiedsimd/unit_tests/include/TestSIMD_Construction.hpp (diff)
The file was modifiedsimd/src/Kokkos_SIMD_AVX2.hpp (diff)
The file was modifiedsimd/unit_tests/include/SIMDTesting_Utilities.hpp (diff)
The file was modifiedsimd/src/Kokkos_SIMD_Common.hpp (diff)
The file was modifiedsimd/unit_tests/include/TestSIMD_Conversions.hpp (diff)
The file was modifiedsimd/src/Kokkos_SIMD_AVX512.hpp (diff)
Commit 770efc3457be65d7bafc2a304c0a32d994aecd4c by Damien L-G
[HIP] Fix atomic performance bug in atomic_fetch_op with [unsigned] long

Co-Authored-By: Thomas Conrad Clevenger <tccleve@sandia.gov>
The file was modifiedtpls/desul/include/desul/atomics/Fetch_Op_HIP.hpp (diff)
Commit 8500d6ddd26092aee1a19dfac561bef55bd0f792 by Damien L-G
Remove gtest filter in AMD MI300A build on HPSF CI

Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
The file was modified.gitlab/hpsf-gitlab-ci.yml (diff)
Commit 31c69c16dd2a3f09c5ef225febbafb901ee7653f by noreply
Add HPSF CI build running on NVIDIA P100 (#7815)

* Add CUDA CI build on NVIDIA P100 on HPSF resources

* Per Daniel's review drop rules redundant with before_step

Co-authored-by: Daniel Arndt <arndtd@ornl.gov>

* While at it prefer nvcr.io server to docker.io

* Fix copy/paste oversight

Co-authored-by: Bruno Turcksin <bruno.turcksin@gmail.com>

---------

Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
Co-authored-by: Bruno Turcksin <bruno.turcksin@gmail.com>
The file was modified.gitlab/hpsf-gitlab-ci.yml (diff)
Commit 79b3104cd563cdb357e702a8d838ac5225187f23 by noreply
Retire kokkos llvm build on ORNL Jenkins (#7801)

* Use Clang 18 in CUDA+Clang build on ORNL Jenkins

Retire Kokkos' LLVM build from our fork.  Use Clang installed from the
system package manager instead.
I chose Clang 18 since version 12 warns that the latest supported
version of CUDA is 10.1
Our fork of LLVM is wildly outdated.

* Use DEBIAN_FRONTEND=noninteractive when installing packages

* Truncate Clang version since we do not have control over it

Co-authored-by: Tomasetti Romin <romin.tomasetti@gmail.com>

* Truncate Clang version since we have no control over it

Co-authored-by: Tomasetti Romin <romin.tomasetti@gmail.com>

* Fix pipeline (use additionalBuildArgs instead of args)

* Fix modernize-type-traits Clang-Tidy check with CUDA

* Temporarily diable bugprone-unchecked-optional-access check in CUDA Graph interop tests

* fixup! Fix modernize-type-traits Clang-Tidy check with CUDA

* Fix bugprone-implicit-widening-of-multiplication-result for CUDA

* Fix clang-diagnostic-deprecated-copy warning with CUDA

* [DO NOT MERGE] try Debug build to get backtraces

* fixup! Fix modernize-type-traits Clang-Tidy check with CUDA

* Change to CUDA 11.8 and Clang 15

* Don't use debug build because that makes one of the test fail

There is a PTX error during assembly.

* Disable -Wpass-failed=... warnings

---------

Co-authored-by: Tomasetti Romin <romin.tomasetti@gmail.com>
Co-authored-by: Christian Trott <crtrott@sandia.gov>
The file was modifiedcore/unit_test/TestWithoutInitializing.hpp (diff)
The file was removedscripts/docker/Dockerfile.kokkosllvmproject
The file was modifiedcore/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)
The file was modifiedcore/unit_test/cuda/TestCuda_Spaces.cpp (diff)
The file was modifiedcore/unit_test/TestTeamBasic.hpp (diff)
The file was modified.jenkins/continuous.groovy (diff)
The file was modifiedcore/unit_test/cuda/TestCuda_InterOp_Graph.cpp (diff)
The file was modifiedcore/src/Cuda/Kokkos_CudaSpace.hpp (diff)
The file was modifiedcore/unit_test/tools/TestWithoutInitializing.cpp (diff)
The file was modifiedcontainers/unit_tests/TestDynViewAPI.hpp (diff)
The file was modifiedscripts/docker/Dockerfile.nvcc (diff)
The file was modifiedcore/src/Cuda/Kokkos_Cuda_Parallel_Range.hpp (diff)
The file was modifiedcore/unit_test/TestViewAPI.hpp (diff)
The file was modifiedcore/src/Cuda/Kokkos_Cuda_ReduceScan.hpp (diff)
The file was modifiedcore/unit_test/TestTeamVector.hpp (diff)
The file was modifiedcore/src/Cuda/Kokkos_Cuda_Instance.hpp (diff)
The file was modifiedcore/src/Cuda/Kokkos_Cuda_Team.hpp (diff)
The file was modifiedcore/src/Cuda/Kokkos_Cuda_KernelLaunch.hpp (diff)
The file was modifiedcore/src/Cuda/Kokkos_Cuda_Parallel_Team.hpp (diff)
The file was modifiedcore/src/Cuda/Kokkos_Cuda_View.hpp (diff)
The file was modifiedcore/unit_test/TestHostSharedPtrAccessOnDevice.hpp (diff)
The file was modifiedcore/src/Cuda/Kokkos_Cuda_WorkGraphPolicy.hpp (diff)