Skip to content
Not built

Changes

Summary

  1. core(cuda): remove unused `show_warnings` (details)
  2. Solve deprecate profiling library warning (details)
  3. Avoid OLD CMP0119: Explicitly add language flag for HIP with hipcc as well (#8415) (details)
  4. Disable compile check for clang + cuda + rdc (#8434) (details)
  5. Fix namespace lookup for symbols in Kokkos_MDSpan_Layout.hpp (details)
  6. Fix compiling with OpenMPTarget (details)
  7. Add missing KOKKOS_FUNCTION annotations on View constructor from nullptr (#8436) (details)
  8. Fix Polaris nightly CI (#8432) (details)
  9. Bump github/codeql-action from 3.30.1 to 3.30.3 (details)
  10. Link kokkoscore directly with CMAKE_DL_LIBS (details)
  11. Drop workaround for GCC 9- in algorithms tests (details)
  12. Move the desul and mdspan hash from scripts/ to tpls/ (details)
  13. Fix RISC-V support (missing semicolon and compiler check) (#8439) (details)
  14. Drop now unnecessary macro guards in Graph interop tests (details)
  15. Drop workaround for libstdc++ 9- with rocThrust without RTTI (details)
  16. [skip-ci]: olcf-nightly: Set FF_ENABLE_JOB_CLEANUP variable (details)
  17. Removed KOKKOS_ENABLE_CXX20 guards (details)
  18. Drop outdated checks for compiler versions in cmake (#8473) (details)
  19. Drop macro guarding exp2(__float128) for GCC 9+ (details)
  20. Drop workaround for GCC 9 in bit manipulation tests (details)
  21. [OpenMPTarget] Get rid of outdated macro guards (details)
  22. Make Timer test more robust (#8433) (details)
  23. Make all new macros IMPL (details)
Commit 218024a6dff2b742644149d839b777d7bc40db4e by romin.tomasetti
core(cuda): remove unused `show_warnings`

Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
The file was modifiedcore/src/Cuda/Kokkos_Cuda_Parallel_Team.hpp (diff)
Commit 248afd4a5a8ddf3a2bcbfd2e6a52f9c527545fa3 by maarten.arnst
Solve deprecate profiling library warning

Signed-off-by: Maarten Arnst <maarten.arnst@uliege.be>
The file was modifiedcmake/fake_tribits.cmake (diff)
Commit 770faf16cf0544dfda01c5ae1e51679778d8964d by noreply
Avoid OLD CMP0119: Explicitly add language flag for HIP with hipcc as well (#8415)

Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
Signed-off-by: Damien L-G <dalg24@gmail.com>
Co-authored-by: Damien L-G <dalg24@gmail.com>
The file was modifiedcmake/kokkos_arch.cmake (diff)
The file was modifiedCMakeLists.txt (diff)
Commit 1924bf5002dcfc8e946b687898ccb3f2f4f552ed by noreply
Disable compile check for clang + cuda + rdc (#8434)

* disable compile check for clang + cuda and rdc
* add a fixme comment

---------

Signed-off-by: Jakob Bludau <bludauj@ornl.gov>
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
The file was modifiedcmake/kokkos_tribits.cmake (diff)
Commit ca7ca21bf086d3f016331762b26ae1f048a5a5ae by Daniel Arndt
Fix namespace lookup for symbols in Kokkos_MDSpan_Layout.hpp

Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
The file was modifiedcore/src/View/MDSpan/Kokkos_MDSpan_Layout.hpp (diff)
Commit e3a4da44f5ed07965cb366ff9fa7fb5ce5085736 by Daniel Arndt
Fix compiling with OpenMPTarget

Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
The file was modifiedcore/src/OpenMPTarget/Kokkos_OpenMPTarget_ParallelFor_Team.hpp (diff)
Commit 1ab7f81775c9af1d9e396a8236e37b7b33df06b2 by noreply
Add missing KOKKOS_FUNCTION annotations on View constructor from nullptr (#8436)

* Let empty runtime unmanaged View test run on the device
* Add missing host device annotation on View constructor from nullptr
* Prefer decltype(nullptr) -> std::nullptr_t
---------

Signed-off-by: Damien L-G <dalg24@gmail.com>
Co-authored-by: Daniel Arndt <arndtd@ornl.gov>
The file was modifiedcore/src/Kokkos_View.hpp (diff)
The file was modifiedcore/unit_test/TestViewEmptyRuntimeUnmanaged.hpp (diff)
Commit 00f5368af8981c1ea91fafebfe010abcc3d5ea3e by noreply
Fix Polaris nightly CI (#8432)

* More std::iterator problems
* Fix Polaris nightly CI

---------

Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
The file was modified.gitlab/alcf-gitlab-ci.yml (diff)
The file was modifiedcore/unit_test/TestMathematicalFunctions.hpp (diff)
Commit 45ab8d861beaf9a4a25c81909c54895163131c3f by noreply
Bump github/codeql-action from 3.30.1 to 3.30.3

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.30.1 to 3.30.3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/f1f6e5f6af878fb37288ce1c627459e94dbf7d01...192325c86100d080feab897ff886c34abd4c83a3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.30.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
The file was modified.github/workflows/codeql.yml (diff)
The file was modified.github/workflows/scorecard.yml (diff)
Commit 60762c5779ca037c5aa0a33ed30f943e27e03115 by Daniel Arndt
Link kokkoscore directly with CMAKE_DL_LIBS

Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
The file was removedcmake/Modules/FindTPLLIBDL.cmake
The file was modifiedcore/src/CMakeLists.txt (diff)
The file was modifiedcmake/kokkos_tpls.cmake (diff)
Commit efefe6204cce8e6d83d20a5da2e9631feae7f2ae by Damien L-G
Drop workaround for GCC 9- in algorithms tests

Our new minimum requirement in 10.4

Signed-off-by: Damien L-G <dalg24@gmail.com>
The file was modifiedalgorithms/unit_tests/TestStdAlgorithmsCommon.hpp (diff)
The file was modifiedalgorithms/unit_tests/TestStdAlgorithmsTeamTransformExclusiveScan.cpp (diff)
The file was modifiedalgorithms/unit_tests/TestStdAlgorithmsTeamTransformInclusiveScan.cpp (diff)
The file was modifiedalgorithms/unit_tests/TestStdAlgorithmsTeamTransformReduce.cpp (diff)
The file was modifiedalgorithms/unit_tests/TestStdAlgorithmsTeamReduce.cpp (diff)
The file was modifiedalgorithms/unit_tests/TestStdAlgorithmsTeamExclusiveScan.cpp (diff)
The file was modifiedalgorithms/unit_tests/TestStdAlgorithmsTeamInclusiveScan.cpp (diff)
Commit 71712b129a47f7f4b0837db847b5efdbe2dee1f5 by trevis.morvany
Move the desul and mdspan hash from scripts/ to tpls/

Signed-off-by: Trévis Morvany <trevis.morvany@cea.fr>
The file was modified.github/workflows/mdspan-version-check.yml (diff)
The file was removedscripts/desul-hash.txt
The file was modified.github/workflows/desul-version-check.yml (diff)
The file was addedtpls/desul-hash.txt
The file was removedscripts/mdspan-hash.txt
The file was addedtpls/mdspan-hash.txt
The file was modifiedcore/src/CMakeLists.txt (diff)
Commit 21490d0645bbf3972bdeb1028e453b4b2e774f41 by noreply
Fix RISC-V support (missing semicolon and compiler check) (#8439)

* Add missing semicolon in declaration of RVV architectures
* Fix incorrect boolean eval for compilers supporting RVV in CMake

---------

Signed-off-by: Prateek Chawla <p.chawla@fz-juelich.de>
Signed-off-by: Prateek Chawla <prateek.chawla168@gmail.com>
Co-authored-by: Damien L-G <dalg24+github@gmail.com>
The file was modifiedcore/src/impl/Kokkos_Core.cpp (diff)
The file was modifiedcmake/kokkos_arch.cmake (diff)
Commit 986f462a25dc74152bb35b6cdd9857f9114c7a25 by Damien L-G
Drop now unnecessary macro guards in Graph interop tests

We require minimum versions GCC 10.4+ and LLVM/Clang 14+

Signed-off-by: Damien L-G <dalg24@gmail.com>
The file was modifiedcore/unit_test/cuda/TestCuda_InterOp_Graph.cpp (diff)
The file was modifiedcore/unit_test/hip/TestHIP_InterOp_Graph.cpp (diff)
The file was modifiedcore/unit_test/sycl/TestSYCL_InterOp_Graph.cpp (diff)
Commit 16526f7ab8bfbe7818f798f65fc2b499e47b01c7 by Damien L-G
Drop workaround for libstdc++ 9- with rocThrust without RTTI

Signed-off-by: Damien L-G <dalg24@gmail.com>
The file was modifiedcmake/kokkos_tpls.cmake (diff)
The file was modifiedcmake/kokkos_tribits.cmake (diff)
Commit d6619772300cbe620f25087865851aa85b942e9c by Bruno Turcksin
[skip-ci]: olcf-nightly: Set FF_ENABLE_JOB_CLEANUP variable

Signed-off-by: Bruno Turcksin <bruno.turcksin@gmail.com>
The file was modified.gitlab/olcf-gitlab-ci.yml (diff)
Commit 5836afdae6de0b41b2b45989d15038a3cf0dd916 by donlee
Removed KOKKOS_ENABLE_CXX20 guards

Signed-off-by: Dong Hun Lee <donlee@sandia.gov>
The file was modifiedsimd/src/Kokkos_SIMD_NEON.hpp (diff)
The file was modifiedsimd/src/Kokkos_SIMD_SVE.hpp (diff)
The file was modifiedsimd/src/Kokkos_SIMD_AVX2.hpp (diff)
The file was modifiedsimd/src/Kokkos_SIMD_Scalar.hpp (diff)
The file was modifiedsimd/src/Kokkos_SIMD_AVX512.hpp (diff)
Commit df2e3023dc1832a3ca4670ca8f81ae9fa8ac560d by noreply
Drop outdated checks for compiler versions in cmake (#8473)

* Drop mdspan workaround for GCC 9-
* Do not bother checking for Clang 14+ with RISC-V archs
* Drop outdated guards for older NVCC
* Drop outdated guards for Clang 4+
* Cleanup more outdated compiler version checks in tests
* Drop unnecessary checks for IntelLLVM 2021-
* Remove now empty corner cases file

---------

Signed-off-by: Damien L-G <dalg24@gmail.com>
The file was modifiedcmake/kokkos_test_cxx_std.cmake (diff)
The file was modifiedcmake/kokkos_enable_options.cmake (diff)
The file was removedcmake/kokkos_corner_cases.cmake
The file was modifiedcmake/kokkos_tribits.cmake (diff)
The file was modifiedcmake/kokkos_arch.cmake (diff)
The file was modifiedcore/unit_test/CMakeLists.txt (diff)
Commit 321e299521cb384e4c0dea669f71af0db52491bc by Damien L-G
Drop macro guarding exp2(__float128) for GCC 9+

Signed-off-by: Damien L-G <dalg24@gmail.com>
The file was modifiedcore/unit_test/TestQuadPrecisionMath.hpp (diff)
The file was modifiedcore/src/impl/Kokkos_QuadPrecisionMath.hpp (diff)
Commit 855b0d739f05f8672e6ad30eaabaa1213137fac9 by Damien L-G
Drop workaround for GCC 9 in bit manipulation tests

Signed-off-by: Damien L-G <dalg24@gmail.com>
The file was modifiedcore/unit_test/TestBitManipulationBuiltins.hpp (diff)
Commit 4db80157cbae67e33031eeb358a8e68aced4cb5e by Damien L-G
[OpenMPTarget] Get rid of outdated macro guards

We only support recent LLVM/Clang versions

Signed-off-by: Damien L-G <dalg24@gmail.com>
The file was modifiedalgorithms/unit_tests/TestStdAlgorithmsMinMaxElementOps.cpp (diff)
The file was modifiedcore/unit_test/TestReducers.hpp (diff)
The file was modifiedcore/unit_test/TestReduce.hpp (diff)
Commit 6a79ad9512b315c4ae500d74cf769cdcef7edbc0 by noreply
Make Timer test more robust (#8433)

The yield of the sleep command for threads may take longer than expected in an uncontrolled fashion.

Signed-off-by: Daniel Arndt <arndtd@ornl.gov>
The file was modifiedcore/unit_test/TestTimer.hpp (diff)
Commit 11122431fc6e0003204f0c8c452ef0c9c8254dd5 by Daniel Arndt
Make all new macros IMPL
The file was modifiedcmake/kokkos_tribits.cmake (diff)
The file was modifiedcore/src/CMakeLists.txt (diff)
The file was modifiedtpls/desul/include/desul/atomics/Lock_Array_CUDA.hpp (diff)
The file was modifiedcore/src/Kokkos_Macros.hpp (diff)
The file was modifiedcore/src/Cuda/Kokkos_Cuda_Instance.hpp (diff)
The file was modifiedcmake/KokkosCore_config.h.in (diff)
The file was modifiedtpls/desul/include/desul/atomics/Macros.hpp (diff)
The file was modifiedcore/src/Cuda/Kokkos_Cuda_Instance.cpp (diff)
The file was modifiedtpls/desul/Config.hpp.cmake.in (diff)